CubeMX ADC Init bug

I discovered the same bug, but there is a deeper problem when using more than 5 channels.

CubeMX (4.0, L4 1.0) generates ADC init code like this:

/**Configure Regular Channel 
 */
 sConfig.Channel = ADC_CHANNEL_8;
 sConfig.Rank = 1;
 sConfig.SamplingTime = ADC_SAMPLETIME_247CYCLES_5;
 sConfig.SingleDiff = ADC_SINGLE_ENDED;
 sConfig.OffsetNumber = ADC_OFFSET_NONE;
 sConfig.Offset = 0;
 if (HAL_ADC_ConfigChannel(&hadc1, &sConfig) != HAL_OK)
 {
 _Error_Handler(__FILE__, __LINE__);
 }�?�?�?�?�?�?�?�?�?�?�?�?

In the mentioned

stm32l4xx_hal_adc.c we find this code:

if (ADC_IS_CONVERSION_ONGOING_REGULAR(hadc) == RESET)
 {
 #if !defined (USE_FULL_ASSERT)
 /* Correspondance for compatibility with legacy definition of */
 /* sequencer ranks in direct number format. This correspondance can */
 /* be done only on ranks 1 to 5 due to literal values. */
 /* Note: Sequencer ranks in direct number format are no more used */
 /* and are detected by activating USE_FULL_ASSERT feature. */
 if (sConfig->Rank <= 5U)
 {
 switch (sConfig->Rank)
 {
 case 2U: sConfig->Rank = ADC_REGULAR_RANK_2; break;
 case 3U: sConfig->Rank = ADC_REGULAR_RANK_3; break;
 case 4U: sConfig->Rank = ADC_REGULAR_RANK_4; break;
 case 5U: sConfig->Rank = ADC_REGULAR_RANK_5; break;
 /* case 1U */
 default: sConfig->Rank = ADC_REGULAR_RANK_1;
 }
 }
 #endif
 
 /* Set ADC group regular sequence: channel on the selected scan sequence rank */
 LL_ADC_REG_SetSequencerRanks(hadc->Instance, sConfig->Rank, sConfig->Channel);�?�?�?�?�?�?�?�?�?�?�?�?�?�?�?�?�?�?�?�?�?�?�?�?�?�?�?�?�?�?�?�?�?�?�?�?�?�?�?�?�?�?�?�?�?�?�?�?

As you can see, if the rank is >5, it is not handled by the switch. This leads to a wrong rank definition if using more than 5 channels with CubeMX!

But the main question is: The comment says

Note: Sequencer ranks in direct number format are no more usedand are detected by activating USE_FULL_ASSERT feature.

It's nice that FULL_ASSERT is detecting the no more used direct number format, but why does CubeMX use it when generating code?

CubeMX generates this:

sConfig.Rank = 1;�?

but shouln't it be this:

sConfig.Rank = ADC_REGULAR_RANK_1;�?

?